-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface help for insecure ports to explain how to disable #71601
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
liggitt:surface-insecure-port-help
Dec 7, 2018
Merged
Surface help for insecure ports to explain how to disable #71601
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
liggitt:surface-insecure-port-help
Dec 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
Nov 30, 2018
k8s-ci-robot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
kind/bug
Categorizes issue or PR as related to a bug.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Nov 30, 2018
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
labels
Nov 30, 2018
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
and removed
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Nov 30, 2018
/retest |
/assign @cheftako |
liggitt
force-pushed
the
surface-insecure-port-help
branch
from
December 7, 2018 13:56
d06a78a
to
819b502
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 7, 2018
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 7, 2018
…1-upstream-release-1.12 Automated cherry pick of #71601: Surface help for insecure ports to explain how to disable
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 10, 2018
…1-upstream-release-1.13 [1.13.1] Automated cherry pick of #71601: Surface help for insecure ports to explain how to disable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The existence of the insecure port flag was incorrectly hidden because it was marked deprecated.
Until the behavior is removed, we must show the flag so users know the default value and how to disable insecure serving.
Will pick this for 1.13.1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #71600
Does this PR introduce a user-facing change?:
/cc @sttts